-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeql updates #31
Codeql updates #31
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for getting this done so quickly.
@fpetrini15 @nvda-mesharma @ganeshku1 Do we just want to run CodeQL on Python? That's what we have historically done. With the PA repo being on its own, it could be a good opportunity to run it on C++ but I notice the time to run CodeQL is now 48 minutes, which is a long runtime for someone to get feedback on their code after pushing a commit. That said, getting C++ to build here was a great idea and I'm open to leaving it. It took a few minutes of scrolling down the build commands to find the build failure (not the best UI for searching the logs for build failures), but it looks like it failed due to needing rapidjson. If we do add the C++ build, we need a bit more work to get it successfully building. |
No description provided.