Use non default git repositories for triton dependencies #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
���ýa:z�kbx! ��ýa:x ��ýa:x
hcho3
approved these changes
Sep 20, 2024
hcho3
reviewed
Sep 20, 2024
| set (REPO_TAG branch-${RAPIDS_DEPENDENCIES_VERSION}) | ||
| # if Triton tag and organization is specified, change the fork and the repo | ||
| if (NOT TRITON_REPO_ORGANIZATION STREQUAL "https://github.com/triton-inference-server") | ||
| set (RAPIDS_FORK ${TRITON_REPO_ORGANIZATION}/rapids_triton.git) |
There was a problem hiding this comment.
My bad for not catching the typo. I will submit a fix right now.
There was a problem hiding this comment.
Hi @hcho3 it's not a typo the mirrored (pb) version is on rapids_triton. We could also change the mirrored gitlab name. @mc-nv @nv-kmcgill53 thoughts?
There was a problem hiding this comment.
In that case, users should be able to specify the full URL, not just the org prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Triton builds containers pre-release, it is useful to allow Rapids and Fil backend to
use non-default remotes.