Skip to content

Commit

Permalink
Add more rules to container version update (#253)
Browse files Browse the repository at this point in the history
* Add more rules to container version update
* Update container versions to 24.06

---------

Signed-off-by: Michał Szołucha <[email protected]>
  • Loading branch information
szalpal authored Jul 31, 2024
1 parent 381d6ff commit 42c461b
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion benchmarks/BM_efficientnet/Dockerfile.torch
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FROM nvcr.io/nvidia/tritonserver:24.05-py3
FROM nvcr.io/nvidia/tritonserver:24.06-py3

RUN pip3 install torch torchvision --index-url https://download.pytorch.org/whl/cu118
2 changes: 1 addition & 1 deletion benchmarks/BM_efficientnet/benchmark-cpu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@ echo "... should be enough."

popd || exit 1

docker run -t --rm --name ${CLIENT_CONTAINER_NAME} --net host -v $(pwd):/bench -w /bench nvcr.io/nvidia/tritonserver:23.07-py3-sdk bash run-benchmarks-cpu.sh $2
docker run -t --rm --name ${CLIENT_CONTAINER_NAME} --net host -v $(pwd):/bench -w /bench nvcr.io/nvidia/tritonserver:24.06-py3-sdk bash run-benchmarks-cpu.sh $2

docker kill ${SERVER_CONTAINER_NAME}
4 changes: 2 additions & 2 deletions benchmarks/BM_efficientnet/benchmark.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ MODEL_REPO="$(pwd)/docs/examples/efficientnet/model_repository"
SERVER_CONTAINER_NAME="efficientnet.server"
CLIENT_CONTAINER_NAME="efficientnet.client"

docker run -dt --rm $DOCKER_RUN_ARGS --name ${SERVER_CONTAINER_NAME} --shm-size=50g --ulimit memlock=-1 --ulimit stack=67108864 --gpus all -p8000:8000 -p8001:8001 -p8002:8002 --privileged -v $MODEL_REPO:/model_repository nvcr.io/nvidia/tritonserver:23.07-py3 tritonserver --model-repository /model_repository --log-verbose 1 --model-control-mode explicit
docker run -dt --rm $DOCKER_RUN_ARGS --name ${SERVER_CONTAINER_NAME} --shm-size=50g --ulimit memlock=-1 --ulimit stack=67108864 --gpus all -p8000:8000 -p8001:8001 -p8002:8002 --privileged -v $MODEL_REPO:/model_repository nvcr.io/nvidia/tritonserver:24.06-py3 tritonserver --model-repository /model_repository --log-verbose 1 --model-control-mode explicit

echo "Waiting for tritonserver to wake up..."
sleep 30
echo "... should be enough."

popd || exit 1

docker run -t --rm --name ${CLIENT_CONTAINER_NAME} --net host -v $(pwd):/bench -w /bench nvcr.io/nvidia/tritonserver:23.07-py3-sdk bash run-benchmarks.sh $2
docker run -t --rm --name ${CLIENT_CONTAINER_NAME} --net host -v $(pwd):/bench -w /bench nvcr.io/nvidia/tritonserver:24.06-py3-sdk bash run-benchmarks.sh $2

docker kill ${SERVER_CONTAINER_NAME}
2 changes: 1 addition & 1 deletion docker/Dockerfile.devel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
# backend together with tritonserver, start from here
# -------------------------------------------------- #

ARG TRITON_VERSION=24.05
ARG TRITON_VERSION=24.06
ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:${TRITON_VERSION}-py3
FROM ${BASE_IMAGE} as builder

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.release
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# the whole tritonserver, start from here.
# -------------------------------------------------- #

ARG TRITON_VERSION=24.05
ARG TRITON_VERSION=24.06
ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:${TRITON_VERSION}-py3
FROM ${BASE_IMAGE} as builder

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ index 00000000..4c180272
--- /dev/null
+++ b/Dockerfile.bench
@@ -0,0 +1,6 @@
+ARG FROM_IMAGE_NAME=nvcr.io/nvidia/pytorch:24.05-py3
+ARG FROM_IMAGE_NAME=nvcr.io/nvidia/pytorch:24.06-py3
+FROM ${FROM_IMAGE_NAME}
+
+ADD . /DeepLearningExamples
Expand Down
2 changes: 2 additions & 0 deletions tools/update_container_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@ sed -i "s|ARG TRITON_VERSION=${version_pattern}|ARG TRITON_VERSION=$1|g" docker/
# Efficientnet example
sed -i "s|+ARG FROM_IMAGE_NAME=nvcr.io/nvidia/pytorch:${version_pattern}-py3|+ARG FROM_IMAGE_NAME=nvcr.io/nvidia/pytorch:$1-py3|g" docs/examples/efficientnet/0001-Update-requirements-and-add-Dockerfile.bench.patch
sed -i "s|FROM nvcr.io/nvidia/tritonserver:${version_pattern}-py3|FROM nvcr.io/nvidia/tritonserver:$1-py3|g" benchmarks/BM_efficientnet/Dockerfile.torch
sed -i "s|nvcr.io/nvidia/tritonserver:${version_pattern}-py3|nvcr.io/nvidia/tritonserver:$1-py3|g" benchmarks/BM_efficientnet/benchmark-cpu.sh
sed -i "s|nvcr.io/nvidia/tritonserver:${version_pattern}-py3|nvcr.io/nvidia/tritonserver:$1-py3|g" benchmarks/BM_efficientnet/benchmark.sh

0 comments on commit 42c461b

Please sign in to comment.