-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Custom Backend Tracing #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandreeva-nv
force-pushed
the
oandreeva-custom-trace-activity
branch
2 times, most recently
from
June 4, 2024 21:35
2c83bfc
to
d839111
Compare
oandreeva-nv
force-pushed
the
oandreeva-custom-trace-activity
branch
from
July 2, 2024 21:33
8bef853
to
9b5d447
Compare
oandreeva-nv
changed the title
[Draft] Custom Trace Activity
[feat]: Custom Backend Tracing
Jul 2, 2024
oandreeva-nv
requested review from
Tabrizian,
indrajit96,
tanmayv25,
nnshah1,
GuanLuo and
krishung5
July 2, 2024 22:17
GuanLuo
reviewed
Jul 3, 2024
GuanLuo
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Currently Triton Trace capabilities are limited to reporting of a predefined set of activities listed here. Neither of the listed options support tracing a custom activity that a potential user might want to capture.
This PR includes core side adjustments, described in TEP:
TRITONSERVER_InferenceTraceReportActivity
TRITONSERVER_TRACE_CUSTOM_ACTIVITY
Sample OpenTelemetry trace:
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Tested with identity backend in server PR: triton-inference-server/server#7403
identity backend: triton-inference-server/identity_backend#30
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)