Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Custom Backend Tracing #351

Merged
merged 14 commits into from
Jul 5, 2024
Merged

Conversation

oandreeva-nv
Copy link
Contributor

@oandreeva-nv oandreeva-nv commented May 9, 2024

What does the PR do?

Currently Triton Trace capabilities are limited to reporting of a predefined set of activities listed here. Neither of the listed options support tracing a custom activity that a potential user might want to capture.

This PR includes core side adjustments, described in TEP:

  • Addition of TRITONSERVER_InferenceTraceReportActivity
  • Introduces only 1 type of new activity: TRITONSERVER_TRACE_CUSTOM_ACTIVITY

Sample OpenTelemetry trace:
image

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

Tested with identity backend in server PR: triton-inference-server/server#7403
identity backend: triton-inference-server/identity_backend#30

  • CI Pipeline ID: 16268312

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #5777

@oandreeva-nv oandreeva-nv force-pushed the oandreeva-custom-trace-activity branch 2 times, most recently from 2c83bfc to d839111 Compare June 4, 2024 21:35
@oandreeva-nv oandreeva-nv force-pushed the oandreeva-custom-trace-activity branch from 8bef853 to 9b5d447 Compare July 2, 2024 21:33
@oandreeva-nv oandreeva-nv marked this pull request as ready for review July 2, 2024 22:00
@oandreeva-nv oandreeva-nv changed the title [Draft] Custom Trace Activity [feat]: Custom Backend Tracing Jul 2, 2024
include/triton/core/tritonbackend.h Outdated Show resolved Hide resolved
src/infer_trace.h Outdated Show resolved Hide resolved
src/infer_trace.h Outdated Show resolved Hide resolved
@oandreeva-nv oandreeva-nv requested a review from GuanLuo July 5, 2024 22:27
@oandreeva-nv oandreeva-nv merged commit 627eb5a into main Jul 5, 2024
1 check passed
@oandreeva-nv oandreeva-nv deleted the oandreeva-custom-trace-activity branch July 5, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants