Protocol fix adding contactPicker and exposing didBegin, didEndEditing #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I know I've dirtied up this patch a bit. I was getting quite confused by all of the "textView"s that actually referred to a textField (I'm guessing your underlying implementation changed). I know this completely breaks any kind of backwards compatibility.. if you want, I'd be willing to re-add the old protocol methods as deprecated. |
|
This would be a great addition to the project. |
|
Hi @eliburke, sorry for the loooong delay in getting to this. I haven't been updating this project much lately. Thanks for the changes to the protocol, they are definitely an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the protocol definition to match what @tomaskraina suggested in #33 and #34 (plus didBeginEditing, which I use to determine which set of values to load into the table for two different contactPickers).