Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Scryer Aug 2020 mod enhancements #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeshan
Copy link

@jeshan jeshan commented Feb 5, 2024

@UWN
Copy link

UWN commented Feb 5, 2024

Does it really make sense to copy the improvements that happened for Scryer's clpz piece-by-piece? Wouldn't it be better to take all of them in one fell swoop?

@jeshan
Copy link
Author

jeshan commented Feb 5, 2024

For mod, I took all of them at once. If you meant for the whole module, then I'm not qualified to work on the clpz codebase! For future PRs, it would surely be better to copy bigger ones at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants