Replace predicate pushdown in the Faker connector with column properties #24323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnector.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnector.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnector.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSource.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public record FakerColumnHandle( | ||
| int columnIndex, | ||
| String name, | ||
| Type type, | ||
| double nullProbability, | ||
| String generator) | ||
| String generator, | ||
| String min, |
There was a problem hiding this comment.
Why? We handle all cases when the value is null.
losipiuk
reviewed
Dec 2, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 2, 2024
losipiuk
reviewed
Dec 2, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
|
I'm still working on this. |
nineinchnick
force-pushed
the
faker-range-properties
branch
2 times, most recently
from
f40d354 to
b2f98a5
Compare
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-range-properties
branch
2 times, most recently
from
90ee9b7 to
67d40c5
Compare
raunaqmorarka
approved these changes
Dec 26, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnector.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-range-properties
branch
from
67d40c5 to
ca22d61
Compare
Allow constraining generated values by setting the min, max, or allowed_values column properties.
Predicate pushdown in the Faker connector violates the SQL semantics, because when applied to separate columns, correlation between columns is not preserved, and returned results are not deterministic. The `min`, `max`, and `options` column properties should be used instead.
nineinchnick
force-pushed
the
faker-range-properties
branch
from
ca22d61 to
2e7ea07
Compare
nineinchnick
force-pushed
the
faker-range-properties
branch
from
2e7ea07 to
383869e
Compare
mosabua
reviewed
Dec 28, 2024
| @@ -166,7 +175,7 @@ Faker supports the following non-character types: | |||
| - `UUID` | |||
|
|
|||
| You can not use generator expressions for non-character-based columns. To limit | |||
| their data range, specify constraints in the `WHERE` clause - see | |||
| their data range, set the `min` and/or `max` column properties - see | |||
There was a problem hiding this comment.
I'll fix this in #24585, I haven't updated the docs there yet.
mosabua
reviewed
Dec 28, 2024
| @@ -102,6 +102,15 @@ The following table details all supported column properties. | |||
| sentence from the | |||
| [Lorem](https://javadoc.io/doc/net.datafaker/datafaker/latest/net/datafaker/providers/base/Lorem.html) | |||
| provider. | |||
| * - `min` | |||
| - Minimum generated value (inclusive). Cannot be set for character-based type | |||
There was a problem hiding this comment.
So does it work for numeric and also date types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Predicate pushdown in the Faker connector violates the SQL semantics,
because when applied to separate columns, correlation between columns is
not preserved, and returned results are not deterministic. The
min,max, andallowed_valuescolumn properties should be used instead.Fixes #24147
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: