Add a timeout for the backend stats collection query #583
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/jdbc-stats-timeout
branch
from
b005207 to
4d3a8a4
Compare
ricardocardante
approved these changes
Jan 2, 2025
oneonestar
reviewed
Jan 7, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsJdbcMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/clustermonitor/TestClusterStatsMonitor.java
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsJdbcMonitor.java
Outdated
Show resolved
Hide resolved
Default the stats collection query to use EXECUTE IMMEDIATE by default, with the option to use explicit PREPARE if desired
willmostly
force-pushed
the
will/jdbc-stats-timeout
branch
from
4d3a8a4 to
69d1e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a timeout for the backend stats collection query.
Default the stats collection query to use EXECUTE IMMEDIATE by default, with the option to use explicit PREPARE if desired
Description
The stats collection query uses the traditional PREPARE/EXECUTE sequence to collect stats on the number of queued and running queries. There is a 10 second timeout on the PREPARE, however there is no timeout on the EXECUTE phase. This can cause issues on clusters that may be able to process the PREPARE quickly, but not the EXECUTE. This is configured as a Duration:
In addition, the default mode has been updated to use EXECUTE IMMEDIATE to skip the prepare step. This has been available since 431. If needed to support earlier versions of Trino, explicit PREPARE can be enabled by setting:
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
* Configure query timeout and use EXECUTE IMMEDIATE for backend stats collection