Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove requests #443

Merged
merged 25 commits into from
Dec 13, 2024
Merged

fix!: remove requests #443

merged 25 commits into from
Dec 13, 2024

Conversation

trim21
Copy link
Owner

@trim21 trim21 commented Jun 9, 2024

BREAKING CHANGE: replace requests with urllib3, now client.timeout is a urllib3.Timeout instance.

@trim21 trim21 changed the title build: remove requests fix!: remove requests Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 85.59322% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (a7c4047) to head (8d7c4dc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
transmission_rpc/client.py 81.66% 11 Missing ⚠️
transmission_rpc/_unix_socket.py 88.00% 3 Missing ⚠️
tests/conftest.py 87.50% 2 Missing ⚠️
transmission_rpc/__init__.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   77.44%   78.01%   +0.56%     
==========================================
  Files          14       15       +1     
  Lines        1521     1574      +53     
==========================================
+ Hits         1178     1228      +50     
- Misses        343      346       +3     
Flag Coverage Δ
3.10 77.44% <77.96%> (-0.01%) ⬇️
3.11 77.44% <77.96%> (-0.01%) ⬇️
3.12 77.44% <77.96%> (-0.01%) ⬇️
3.8 76.60% <77.77%> (-0.66%) ⬇️
3.9 77.24% <77.77%> (-0.02%) ⬇️
unix-socket 77.56% <85.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21 trim21 merged commit 8d2ee2c into master Dec 13, 2024
22 checks passed
@trim21 trim21 deleted the build/requests branch December 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants