Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][UMA-1116][UMA-1146] WallectConnect validates proposals and requests #2373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dianasavvatina
Copy link
Contributor

@dianasavvatina dianasavvatina commented Feb 6, 2025

Proposed changes

UMA-1116 Beacon and WalletConnect bug: tx confirmation is allowed after dApp has disconnected
UMA-1146 WalletConnect bug: wallet allows to confirm an expired request

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Request

  1. connect dapp, e.g. https://taquito-test-dapp.pages.dev/
  2. send request, e.g. send tez
  3. wait till the modal opens on wallet; then disconnect dApp
  4. try to reject or confirm the operation

Session proposal:

  1. connect dapp, e.g. https://taquito-test-dapp.pages.dev/
  2. wait till the modal opens on wallet; then disconnect dApp; open the QR code again
  3. try to reject or confirm the session proposal

Another way to reproduce is wait for 5 minutes to make sure the request/proposal has expired.

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Scenario Before Now
Approve request, walletKit doesn't have this request image image
Session Proposal, walletKit doesn't have this session on approval image
Session Proposal, walletKit has this session but approval fails image image
Session Proposal, walletKit has session proposal but reject fails image
Session Request rejected after dApp disconnected image No toast image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:50am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:50am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:50am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:50am

@dianasavvatina dianasavvatina self-assigned this Feb 6, 2025
@dianasavvatina dianasavvatina force-pushed the UMA-1116/wc-validates-requests branch from daeeb09 to 0c74c1d Compare February 6, 2025 16:20
@dianasavvatina dianasavvatina force-pushed the UMA-1116/wc-validates-requests branch from 0c74c1d to fa586c4 Compare February 6, 2025 16:44
@dianasavvatina dianasavvatina force-pushed the UMA-1116/wc-validates-requests branch from fa586c4 to 0b8975e Compare February 6, 2025 17:00
@dianasavvatina dianasavvatina changed the title [Web][UMA-1116] WallectConnect validates proposals and requests [Web][UMA-1116][UMA-1146] WallectConnect validates proposals and requests Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant