-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web][UMA-1116][UMA-1146] WallectConnect validates proposals and requests #2373
Open
dianasavvatina
wants to merge
1
commit into
main
Choose a base branch
from
UMA-1116/wc-validates-requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daeeb09
to
0c74c1d
Compare
0c74c1d
to
fa586c4
Compare
fa586c4
to
0b8975e
Compare
0b8975e
to
52a9389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
UMA-1116 Beacon and WalletConnect bug: tx confirmation is allowed after dApp has disconnected
UMA-1146 WalletConnect bug: wallet allows to confirm an expired request
Types of changes
Steps to reproduce
Request
Session proposal:
Another way to reproduce is wait for 5 minutes to make sure the request/proposal has expired.
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist