feat: earn tab texts #2344
Merged
feat: earn tab texts #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
requested changes
Feb 3, 2025
apps/web/src/views/Earn/Earn.tsx
Outdated
| subtitle={"Maximize your tez with staking.com.\nSecure, efficient, and simple."} | ||
| title="Boost your rewards" | ||
| /> | ||
| delegate === null || delegate === undefined ? ( |
There was a problem hiding this comment.
Try not to use nested ternary operators, instead it is better to use if/else inside getCtaMessage which will return the appropriate jsx
OKendigelyan
approved these changes
Feb 3, 2025
apps/web/src/views/Earn/Earn.tsx
Outdated
| return <VerifyMessage />; | ||
| } | ||
|
|
||
| if (delegate === null || delegate === undefined) { |
There was a problem hiding this comment.
Suggested change
| if (delegate === null || delegate === undefined) { | |
| !delegate { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Earn tab text depends on account state:
Start earningStakeManage fundsDesign: Notion
UMA-1114
Types of changes
Steps to reproduce
See
Earntab.Screenshots
Add the screenshots of how the app used to look like and how it looks now
Before:
Checklist