Tpetra: Don't test need_sync_[host|device]

[masterleinad]

@trilinos/tpetra

Motivation

kokkos/kokkos#7775 proposes to skip modify and sync if DualView only references one View, i.e., if the memory space is host-accessible. This changes the behavior of DualView::need_sync_[host|device] and thus
Tpetra::MultiVector::need_sync_[host|device] which just calls the respective DualView function, see

Trilinos/packages/tpetra/core/src/Tpetra_MultiVector_def.hpp

Lines 4494 to 4506 in 74d6091

	template <class Scalar, class LocalOrdinal, class GlobalOrdinal, class Node>
	bool
	MultiVector<Scalar, LocalOrdinal, GlobalOrdinal, Node>::
	need_sync_host () const {
	return view_.need_sync_host ();
	}
	template <class Scalar, class LocalOrdinal, class GlobalOrdinal, class Node>
	bool
	MultiVector<Scalar, LocalOrdinal, GlobalOrdinal, Node>::
	need_sync_device () const {
	return view_.need_sync_device ();
	}

. One of the Tpetra unit tests checks this behavior explicitly and therefore breaks with kokkos/kokkos#7775.
This pull request proposes to just remove this particular check since the MultiVector function only forwards anyway.
An alternative would be to use

constexpr bool needsSyncPath = !Kokkos::SpaceAccessibility<Kokkos::HostSpace, typename device_t::memory_space>::accessible;

once Kokkos is updated in Trilinos.

Testing

Running all Tpetra unit tests with a configuration that has Kokkos_ENABLE_CUDA_UVM=ON.

[trilinos-autotester]

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.