-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STK: Don't access DualView's [h|d]_view directly #13788
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@ldh4 can you bring this change to sierra?
|
The changes here don't require any recent Kokkos version, though. |
Yep, I realized it right after making that comment. |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
@masterleinad DCO |
Signed-off-by: Daniel Arndt <[email protected]>
ef35c18
to
62d968b
Compare
That should be all of them. |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
@trilinos/stk
Motivation
kokkos/kokkos#7716 proposes to deprecate the ability to access
DualView
'sh_view
andd_view
members directly since modifying the allocations can get perturbed theDualView
's internal status. This pull request replaces all places inSTK
that use these members directly, in most places, verbatim withview_device
resp.view_host
.Related Issues
Related to kokkos/kokkos#7716.
Signed-off-by: Daniel Arndt [email protected]