Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce NFC driver with RFAL middleware #4566
base: main
Are you sure you want to change the base?
Introduce NFC driver with RFAL middleware #4566
Changes from 7 commits
28b4f01
c0a5522
1af9771
f75fe14
3488569
606d8c9
b241955
3a147fa
a3136e2
d0ecd9f
840d7d7
bd5de3a
9ca4e03
f9f3d1a
d962d63
9a41feb
073bd6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use different approach, which is polling for events and i think we should keep the same style here. So instead of this register function and nfc_feed_worker, the api would have single nfc_get_event (see i.e. ble_get_event for reference), which would internally call nfc_feed_worker. Internally, you could put the events into <util/tsqueue.h> if there is a need to store multiple events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is bit more complex in NFC case, because optimally you want to make an user action in the middle of the rfal worker process right after device get discovered and deactivate the device at the end of the same routine. But I think i managed to refactor that in d0ecd9f by pulling out the deactivate function to nfc lib api. Thanks for double checking!
Large diffs are not rendered by default.