Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust T3W1 display refresh rate #4551

Merged
merged 1 commit into from
Jan 31, 2025
Merged

adjust T3W1 display refresh rate #4551

merged 1 commit into from
Jan 31, 2025

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Jan 29, 2025 •
edited
Loading

This PR adjusts T3W1 display refresh rate to be closer to 60Hz.

This is done by adjusting lane byte frequency, as opposite to adjusting porch setting, after discussing this with display supplier.

@TychoVrahe TychoVrahe self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe requested a review from cepetr January 30, 2025 15:38
@TychoVrahe TychoVrahe marked this pull request as ready for review January 30, 2025 15:38
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner January 30, 2025 15:38
@TychoVrahe TychoVrahe removed the request for review from prusnak January 30, 2025 15:38
cepetr
cepetr approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did few calculations and it looks good. Tested on D002 and A0 rev of T3W1.

@TychoVrahe TychoVrahe merged commit 64d8c18 into main Jan 31, 2025
94 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/T3W1/refresh_rate branch January 31, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TychoVrahe @cepetr