Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): explicitly delete keyboard layout #4540

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(core): explicitly delete keyboard layout #4540

merged 1 commit into from
Jan 27, 2025

Conversation

obrusvit
Copy link
Contributor

  • seems that keyboard LayoutObj was not properly deallocated resulting in MemoryError. Fix by calling the dunder del method explicitly fixes the issue
  • the problem was on Model T (Bolt), but applying it for all layouts to prevent similar problem

@obrusvit
fix(core): explicitly delete keyboard layout
3ff621e 
- seems that keyboard LayoutObj was not properly deallocated resulting
in MemoryError. Fix by calling the dunder `del` method explicitly fixes
the issue
- the problem was on Model T (Bolt), but applying it for all layouts to
prevent similar problem
@obrusvit obrusvit added bug Something isn't working as expected hardware only Issue which does not appear on the emulator - but on physical device only. T2T1 Trezor Model T labels Jan 27, 2025
@obrusvit obrusvit self-assigned this Jan 27, 2025
@obrusvit obrusvit requested a review from matejcik as a code owner January 27, 2025 14:38
@obrusvit obrusvit linked an issue Jan 27, 2025 that may be closed by this pull request
Recovery and check backup of 33 word seed on Model T fails for the first time #4537
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

matejcik
matejcik approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@obrusvit obrusvit added hardware only Issue which does not appear on the emulator - but on physical device only. and removed hardware only Issue which does not appear on the emulator - but on physical device only. labels Jan 27, 2025
@obrusvit obrusvit merged commit 15967a3 into main Jan 27, 2025
161 checks passed
@obrusvit obrusvit deleted the obrusvit/fix-4537-recovery-and-check-backup-of-33-word-seed branch January 27, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

Assignees

@obrusvit obrusvit

Labels
bug Something isn't working as expected hardware only Issue which does not appear on the emulator - but on physical device only. T2T1 Trezor Model T
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recovery and check backup of 33 word seed on Model T fails for the first time
2 participants
@obrusvit @matejcik