Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to trezor-common #4530

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Jan 23, 2025

  • Update backend urls of XRP, test XRP, ADA, test ADA and test SOL
  • Add labels to EVMs because native tokens are different for L2s and we need that is Suite repo
  • Change BNB to BSC (correct network symbol) and finish migration of MATIC to POL
  • Add Arbitrum One, Base, Optimism
    • The most required commit to be able to update coins page on trezor.io

PR in suite repo trezor/trezor-suite#16576

@tomasklim tomasklim requested a review from matejcik as a code owner January 23, 2025 16:30
@tomasklim tomasklim changed the title chore(common): remove build-in token defs Updates to trezor-common Jan 23, 2025
@matejcik
Copy link
Contributor

this crude of a removal most certainly does not solve #4240
please revert that part of the change, we'll need to resolve this at usage sites first and only then remove the actual data

@tomasklim tomasklim force-pushed the tomasklima/trezor-common branch from 0b8d0e7 to 087a72f Compare January 24, 2025 15:07
@tomasklim
Copy link
Member Author

@matejcik done dropped

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on altcoin string detection: please edit tools/check-bitcoin-only and add "base" to exceptions (that's a rather common word so we need to not recognize it as an altcoin name :) )

please also run make gen and commit the results

@tomasklim
Copy link
Member Author

Added base here 9df5965

@tomasklim
Copy link
Member Author

please also run make gen and commit the results

@matejcik could you please run it for me? I am getting errors

$ make gen               
python3 core/tools/build_icons.py
layout_bolt icon size: 26577 bytes
layout_delizia icon size: 13239 bytes
make -C core templates
make[1]: layout_parser: Command not found
make[1]: layout_parser: Command not found
expr: syntax error
make[1]: layout_parser: Command not found
make[1]: layout_parser: Command not found
expr: syntax error
python ./translations/order.py
No new items found.
python ./translations/cli.py gen
Traceback (most recent call last):
  File "trezor-firmware/core/./translations/cli.py", line 12, in <module>
    from trezorlib import cosi, models, merkle_tree
ImportError: cannot import name 'merkle_tree' from 'trezorlib' (/opt/homebrew/lib/python3.10/site-packages/trezorlib/__init__.py)
make[1]: *** [translations] Error 1
make: *** [templates] Error 2

@matejcik
Copy link
Contributor

you are either not in poetry shell or your env is outdated; do poetry install; poetry run make gen

@tomasklim tomasklim force-pushed the tomasklima/trezor-common branch from 93264a6 to f816fc1 Compare January 28, 2025 12:46
@matejcik matejcik merged commit 7876895 into trezor:main Jan 28, 2025
91 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants