-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to trezor-common #4530
Updates to trezor-common #4530
Conversation
this crude of a removal most certainly does not solve #4240 |
0b8d0e7
to
087a72f
Compare
@matejcik done dropped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing on altcoin string detection: please edit tools/check-bitcoin-only
and add "base" to exceptions (that's a rather common word so we need to not recognize it as an altcoin name :) )
please also run make gen
and commit the results
087a72f
to
9df5965
Compare
Added |
@matejcik could you please run it for me? I am getting errors $ make gen
python3 core/tools/build_icons.py
layout_bolt icon size: 26577 bytes
layout_delizia icon size: 13239 bytes
make -C core templates
make[1]: layout_parser: Command not found
make[1]: layout_parser: Command not found
expr: syntax error
make[1]: layout_parser: Command not found
make[1]: layout_parser: Command not found
expr: syntax error
python ./translations/order.py
No new items found.
python ./translations/cli.py gen
Traceback (most recent call last):
File "trezor-firmware/core/./translations/cli.py", line 12, in <module>
from trezorlib import cosi, models, merkle_tree
ImportError: cannot import name 'merkle_tree' from 'trezorlib' (/opt/homebrew/lib/python3.10/site-packages/trezorlib/__init__.py)
make[1]: *** [translations] Error 1
make: *** [templates] Error 2
|
you are either not in |
93264a6
to
f816fc1
Compare
PR in suite repo trezor/trezor-suite#16576