Startup/shutdown refactoring #4499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cepetr
force-pushed
the
cepetr/shutdown-refactoring
branch
7 times, most recently
from
13b756d to
e3542c3
Compare
cepetr
added
bootloader core
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
cepetr
force-pushed
the
cepetr/shutdown-refactoring
branch
from
e3542c3 to
d4cd1a3
Compare
[no changelog]
TychoVrahe
reviewed
Jan 20, 2025
|
|
||
| // Adds a new address range into the memory region. | ||
| // | ||
| // The rabge start and end pointers must be aligned to the 4 bytes. |
| @@ -41,6 +42,10 @@ | |||
| #include "zkp_context.h" | |||
| #endif | |||
|
|
|||
| // symbols defined in the linker script | |||
| extern uint8_t _stack_section_start; | |||
There was a problem hiding this comment.
maybe we can move the extens to linker_utils?
| // Wait for the user to manually power off the device | ||
| secure_shutdown(); | ||
| // Wait for the user to read the RSOD and then reboots | ||
| // (or enters an infinite loop if RSOD_INFINITE_LOOP is defined) |
There was a problem hiding this comment.
the need for this comment indicates that the function name is not ideal
| // recommended to call it only during the startup sequence. | ||
| void clear_unused_stack(void); | ||
|
|
||
| // |
| void* start; | ||
| // block end address (exclusive) | ||
| void* end; | ||
| } memregion_block_t; |
There was a problem hiding this comment.
we have similar memory_area_t used in applet code (thought it is start+size instead of end, but its equivalent). Would it make sense to use same structure there, and perhaps the supporting functions for clearing?
| #endif | ||
|
|
||
| #ifdef BOARDLOADER | ||
| memregion_fill(®ion, 0xFFFFFFFF); // do we really need this??? |
There was a problem hiding this comment.
this was originally value from TRNG. Whether its actually useful is unclear to me
| #endif | ||
|
|
||
| #ifdef BOARDLOADER | ||
| memregion_fill(®ion, 0xFFFFFFFF); // !@# do we really need this??? |
There was a problem hiding this comment.
this was originally value from TRNG
| // Fill memory region with a value 32-bit value | ||
| void memregion_fill(memregion_t* region, uint32_t value); | ||
|
|
||
| #define MEMREGION_ADD_SECTION(region, section_name) \ |
There was a problem hiding this comment.
unused, along with the memregion_add_range section. Intentionally? If so, do we need to keep it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes significant refactoring of the startup and shutdown code.