Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisig fix in legacy #4396

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Multisig fix in legacy #4396

wants to merge 6 commits into from

Conversation

onvej-sl
Copy link
Contributor

This pull request backports #4351 to legacy.

@onvej-sl onvej-sl added the T1B1 legacy Trezor One label Nov 27, 2024
@onvej-sl onvej-sl force-pushed the onvej-sl/multisig-fix-legacy branch from b2a9b63 to 4839e37 Compare December 2, 2024 15:35
@onvej-sl onvej-sl force-pushed the onvej-sl/multisig-fix-legacy branch from 4839e37 to c9adb55 Compare December 4, 2024 15:28
@onvej-sl onvej-sl marked this pull request as ready for review December 4, 2024 16:05
@onvej-sl onvej-sl requested review from andrewkozlik and mmilata and removed request for prusnak and matejcik December 4, 2024 16:06
@andrewkozlik andrewkozlik removed their request for review January 22, 2025 12:19
Comment on lines +315 to +317
_("Using different paths for different xpubs is not allowed"

));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
_("Using different paths for different xpubs is not allowed"
));
_("Using different paths for different xpubs is not allowed"));

layoutHome();
return;
}
fsm_layoutDifferentPathsWarning();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User pressing Cancel is not handled here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1B1 legacy Trezor One
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants