Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Avian AVN coin support (altcoin based on Bitcoin code) #3961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Refloow
Copy link

@Refloow Refloow commented Jun 19, 2024

No description provided.

@Refloow Refloow requested a review from matejcik as a code owner June 19, 2024 00:20
@Refloow
Copy link
Author

Refloow commented Jul 22, 2024

Can we know if there are any additional edits needed, or do we need to provide any more data for Avian to be integrated?
Integration followed the rules & guidelines in documentation for adding altcoins based on bitcoin code.
A publication post about this pull request was made from official Avian Network twitter account: https://x.com/avianfoundation/status/1805278579162268048
Electrum would be used for wallet connectivity. Everything has been integrated, tested & finished on our end:
https://github.com/AvianNetwork/electrum-avian/releases
Looking forward to hearing from you soon, thanks in advance

@matejcik matejcik requested review from Hannsek and removed request for matejcik September 30, 2024 11:49
@Hannsek
Copy link
Contributor

Hannsek commented Oct 1, 2024

Hi, sorry for the delayed message. We'll merge this soon if there are no troubles.

Please also add Trezor HW as a supported wallet to here if possible.

@Hannsek Hannsek requested review from matejcik and removed request for matejcik and Hannsek October 1, 2024 11:02
@matejcik
Copy link
Contributor

matejcik commented Oct 1, 2024

@Refloow you will want to use ./common/tools/support.py to add support info for all models (that is currently T1B1, T2T1, T2B1, T3T1, T3B1). support.py --help or the readme in common/tools explains the process.

please also make sure make gen and make style run and the results are checked into this PR.

please rebase on top of current main so that we can get the CI results

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(marking "changes requested" per the above comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants