Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trezor-client): fix convert_signature invalid s conversion #3952

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

TuDo1403
Copy link
Contributor

Description:

  • This PR fixes Invalid convert_signature function in trezor-client Package

Problem:

The current implementation of the convert_signature function in the trezor-client package contains a potential error in the way the signature's s component is handled. Specifically, the line:

let s = resp.signature_r().try_into().map_err(|_| Error::MalformedSignature)?;

This line incorrectly references resp.signature_r() instead of resp.signature_s(), leading to a logical error where the r component is duplicated as s.

Please review the changes and merge them if they meet the project's standards. Thank you for considering this fix.

@TuDo1403 TuDo1403 changed the title fix(trezor-client): fix convert_signature invalid s convert fix(trezor-client): fix convert_signature invalid s conversion Jun 14, 2024
@prusnak prusnak requested a review from matejcik June 14, 2024 16:32
@matejcik matejcik merged commit ac1a25f into trezor:main Jun 17, 2024
82 of 83 checks passed
@prusnak
Copy link
Member

prusnak commented Jul 12, 2024

https://crates.io/crates/trezor-client/0.1.4 with the change released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants