-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust macros and types cleanup #3951
Conversation
|
Feel free to include #3953 |
Do you think we could achieve formatting translated template strings with let text = TR::reset__select_word_x_of_y_template.map_translated(|s| {
uformat!(s, n_choice, n_words)
});
|
we can't because the format literals are parsed at compile-time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup
now that we have c"..." literals in Rust
now that we have ufmt, this is just much nicer
removing inttostr!, build_string!, and relocating include_res!
This commit removes the last usage of StringType. In the future, we use TString. [no changelog]
b95c2c2
to
8846620
Compare
building on top of #3938 for the
dbg_print!
macrosCStr
in favor of a stand-alone cratec""
string literals in favor ofcstr!
macrouformat!
convenience macro that will return (by default) aShortString
with the formatting result.unwrap!(uformat!())
everywhere, that's pure noise.uwrite!
on it manuallyShortString
instead of picking a size ad hoc and carrying multiple copies ofString<N>
#[macro_use]
to exactly one place (themacros
module in root). Import all other macros as needed (so things likeobj_type!
are explicitly imported frommicropython::macros
. Seems just plain nicer.)debug
feature)