Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backlight driver refactoring #3950

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Backlight driver refactoring #3950

merged 1 commit into from
Jul 8, 2024

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Jun 14, 2024

This PR is about refactoring the backlight driver and preparing it for entering and exiting low-power modes (not done yet).

  1. Simplified and clarified the driver API and removed model-specific functions.
  2. Eliminated multiple global variables and introduced a single driver instance variable.
  3. Slightly changed the driver logic without affecting its functionality.

This PR will be followed by the display driver refactoring, where additional cleanup will be done.

@cepetr cepetr added T2T1 Trezor Model T T3T1 Trezor Safe 5 labels Jun 14, 2024
@cepetr cepetr requested a review from TychoVrahe June 14, 2024 11:24
@cepetr cepetr self-assigned this Jun 14, 2024
@cepetr cepetr requested a review from prusnak as a code owner June 14, 2024 11:24
@cepetr cepetr force-pushed the cepetr/low-power-haptic branch from 715a817 to 450eed6 Compare June 14, 2024 12:48
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch from 7cb708c to 08bc0fb Compare June 14, 2024 12:48
core/embed/trezorhal/stm32f4/backlight_pwm.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32f4/backlight_pwm.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32f4/backlight_pwm.h Outdated Show resolved Hide resolved
@cepetr cepetr force-pushed the cepetr/low-power-haptic branch from 0d4c7c4 to 05feaa1 Compare June 18, 2024 08:57
@cepetr cepetr requested a review from matejcik as a code owner June 18, 2024 08:57
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch from 5632770 to e9dd7d5 Compare June 18, 2024 08:58
@cepetr cepetr force-pushed the cepetr/low-power-haptic branch from 05feaa1 to 3aa64bc Compare June 19, 2024 08:46
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch from e9dd7d5 to d024773 Compare June 19, 2024 08:46
@cepetr cepetr force-pushed the cepetr/low-power-haptic branch 2 times, most recently from f8c77b0 to 1c262fd Compare June 19, 2024 12:04
Base automatically changed from cepetr/low-power-haptic to main June 19, 2024 12:05
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch 2 times, most recently from 6f57cc8 to fb87cc9 Compare June 19, 2024 14:42
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch from fb87cc9 to 9e5e90a Compare June 22, 2024 06:51
@cepetr cepetr force-pushed the cepetr/low-power-backlight branch from 9e5e90a to 14f2093 Compare July 8, 2024 07:44
@cepetr cepetr merged commit 5996198 into main Jul 8, 2024
79 of 83 checks passed
@cepetr cepetr deleted the cepetr/low-power-backlight branch July 8, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2T1 Trezor Model T T3T1 Trezor Safe 5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants