Haptic driver refactoring #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cepetr
force-pushed
the
cepetr/low-power-touch
branch
from
e9f6dca to
266a436
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
5aeb473 to
715a817
Compare
cepetr
force-pushed
the
cepetr/low-power-touch
branch
2 times, most recently
from
8f539c7 to
a87c8bf
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
715a817 to
450eed6
Compare
TychoVrahe
approved these changes
Jun 17, 2024
cepetr
force-pushed
the
cepetr/low-power-touch
branch
from
50f67d5 to
c03a3df
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
0d4c7c4 to
05feaa1
Compare
cepetr
force-pushed
the
cepetr/low-power-touch
branch
2 times, most recently
from
6c77b40 to
e25ade5
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
05feaa1 to
3aa64bc
Compare
cepetr
force-pushed
the
cepetr/low-power-touch
branch
2 times, most recently
from
b54306e to
2723ee1
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
3aa64bc to
f8c77b0
Compare
cepetr
force-pushed
the
cepetr/low-power-haptic
branch
from
f8c77b0 to
1c262fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on refactoring the haptic controller driver. It does not fix any problems or introduce new features, but includes the following changes:
haptic_calibrate()since it's unused, and using calibration requires more effort than just having this routine.HAPTIC_ALERTeffect since it's unused.haptic.h). Added thehaptic_deinit()function, allowing repeated driver initialization and deinitialization, and ensured all functions that can fail returnbool.The original goal was to prepare the haptic driver for power management features (e.g., suspending before entering low power modes and resuming after returning to full power).