Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider renaming stack variables #4199

Open
TychoVrahe opened this issue Sep 20, 2024 · 0 comments · May be fixed by #4499
Open

consider renaming stack variables #4199

TychoVrahe opened this issue Sep 20, 2024 · 0 comments · May be fixed by #4499
Labels
code Code improvements

Comments

@TychoVrahe
Copy link
Contributor

In linker scripts, we currently have variables:
_sstack
_estack
These names are not ideal. Maybe we should give them better names, as suggested in #4188 (comment)
@TychoVrahe TychoVrahe added the code Code improvements label Sep 20, 2024
@TychoVrahe TychoVrahe mentioned this issue Sep 20, 2024
Merged
@TychoVrahe TychoVrahe linked a pull request Jan 17, 2025 that will close this issue
Startup/shutdown refactoring #4499
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code improvements
Projects
Firmware
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Startup/shutdown refactoring trezor/trezor-firmware
1 participant
@TychoVrahe