Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new configuration option to give the user the option to choose the node expoter target.
The new parameter is
node-exporter-target
in the command line and configuration file.If the option is not used, the code will use the lowest ipv4 address plus the default node exporter port.
And it will send a new field in the host discovery as
prometheus_targets
with amap[string]string
with all the configured exporters.I have chosen this option to enable future exporters usage. In this case:
How was this tested?
UT
Did you update the documentation?
I added some "in code" documentation, but we will need to add this new value in additional places I guess