Sapservices gatherer

[CDimonaco]

Gatherer for sapservices file, by default /usr/sap/sapservices.

Return each entry of sapservices file as a map, with the kind of startup system used, systemd or sapservices

[arbulu89]

The code logic looks totally correct.
I'm wondering if we should do some integrity check on the line contents. I mean, to check if the line with systemctl or sapstartsrv follows the correct structure

[arbulu89]

Remember to add the gatherer to the list of available gatherers
Maybe you can "mix" the 2 success tests to avoid the "duplicated" warning message

[rtorrero]

Thanks @CDimonaco, looks good to me overall but the names of the tests and content of the errors need some fixing

[rtorrero]

Approving as we had a chat and its now clear what I meant, feel free to fix and merge when ready 👍

[arbulu89]

Looks good! Some cosmetic suggestions.
At least fix the alphabetical ordering of the getherer.go file.
About the linting error, I guess you will need to put some nolint flag there, don't merge with the error please