Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to portcheck service #3

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Add IPv6 support to portcheck service #3

merged 2 commits into from
Feb 19, 2023

Conversation

titer
Copy link
Member

@titer titer commented Feb 10, 2023

Fixes: #1

  • Use getaddrinfo+AI_NUMERICHOST instead of the IPv4-only inet_addr
  • Add small test for IPv4 and v6 port checks

Using getaddrinfo+AI_NUMERICHOST instead of the IPv4-only inet_addr
@kelson42
Copy link

@ckerr Any chance you could review the PR @titer was kind enough to provide? If merged, I guess he could deploy it straight and that way this ~10 years old problem would be finally behind us!

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @titer 💚

@ckerr ckerr merged commit 23d88c1 into master Feb 19, 2023
@ckerr ckerr deleted the ipv6-support branch February 19, 2023 15:23
@ckerr
Copy link
Member

ckerr commented Feb 19, 2023

@titer next question, how does deployment work? 😸

@titer
Copy link
Member Author

titer commented Feb 24, 2023

@ckerr thanks for the review!
I'm adding a bit of documentation in #5 - you don't seem to have access yet but I can add your ssh key any time.
This change is now deployed and the IPv6 check works fine for me

@ckerr
Copy link
Member

ckerr commented Feb 24, 2023

@titer TBH the fewer tertiary things I have to know about / care about / fix when they break, the better. 🙂

If it could just redeploy whenever something's merged to the repo that would be so much better than if a year from now I have to dig out my notes on how I deployed it back in March of '23

@kelson42
Copy link

kelson42 commented Feb 24, 2023

@ckerr We could build automatically a container image here using Github actions and then we just need to find a way to trigger the recreation of the container?! Something like https://hub.docker.com/r/containrrr/watchtower/ might be a solution. This is at least the kind of approach I would choose.

@ckerr
Copy link
Member

ckerr commented Feb 24, 2023

I just want it to work; however @titer wants to do is fine with me.

...though it is nice to see Eric again thanks to this portcheck feature, so maybe it's sometimes a Good Thing for something to break once in awhile 😸

@dunxd

This comment was marked as off-topic.

@ckerr

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Portcheck broken for ipv6 capable systems.
4 participants