-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support to portcheck service #3
Conversation
Using getaddrinfo+AI_NUMERICHOST instead of the IPv4-only inet_addr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks @titer 💚
@titer next question, how does deployment work? 😸 |
@titer TBH the fewer tertiary things I have to know about / care about / fix when they break, the better. 🙂 If it could just redeploy whenever something's merged to the repo that would be so much better than if a year from now I have to dig out my notes on how I deployed it back in March of '23 |
@ckerr We could build automatically a container image here using Github actions and then we just need to find a way to trigger the recreation of the container?! Something like https://hub.docker.com/r/containrrr/watchtower/ might be a solution. This is at least the kind of approach I would choose. |
I just want it to work; however @titer wants to do is fine with me. ...though it is nice to see Eric again thanks to this portcheck feature, so maybe it's sometimes a Good Thing for something to break once in awhile 😸 |
Fixes: #1