Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial LLVM 17 support #274

Merged
merged 6 commits into from
Feb 2, 2024
Merged

initial LLVM 17 support #274

merged 6 commits into from
Feb 2, 2024

Conversation

woodruffw
Copy link
Member

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw self-assigned this Feb 2, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@@ -21,7 +21,8 @@ jobs:
run: |
wget https://apt.llvm.org/llvm.sh
chmod +x llvm.sh
sudo ./llvm.sh 15
sudo ./llvm.sh 17
sudo apt install -y libpolly-17-dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: At some point LLVM appears to have dropped Polly from their default library base in llvm.sh. The llvm-ir crate needs it, so I've added it manually in each install step.

@woodruffw woodruffw requested a review from smoelius February 2, 2024 17:10
Copy link
Collaborator

@smoelius smoelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one small comment.

@smoelius
Copy link
Collaborator

smoelius commented Feb 2, 2024

I have just one small comment.

Please just go ahead an merge once you've had a chance to consider it.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw merged commit 8ec4333 into master Feb 2, 2024
3 checks passed
@woodruffw woodruffw deleted the ww/llvm-17 branch February 2, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants