Henrik/mlir linkage b and c #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the linkage-b test pass. There is still some work to be done with respect to DataLayout. The current approach uses attributes directly. Moving forward, this should probably use either the DataLayout interfaces or a custom DataLayout structure.
xlauko
reviewed
Feb 14, 2025
| /*methodName=*/ "setLinkage", | ||
| /*args=*/(ins "::mlir::link::Linkage":$linkage), | ||
| /*methodBody=*/"", | ||
| /*defaultImplementation=*/[{ }] |
There was a problem hiding this comment.
I would like this not to stay empty. As it might be source of bugs if you forget to implement it.
There was a problem hiding this comment.
Good catch! That's an oversight of me. I'll fix it.
There was a problem hiding this comment.
I'm struggling a bit to get this working. To clarify, did you intend for me to implement either of these scenarios?
/*defaultImplementation=*/""/*defaultImplementation=*/[{ actual default implementation }]
Right now, no matter how I do this (seemingly) I get redeclaration errors. I think this might have something to do:
def LLVM_GlobalOp : LLVM_Op<"mlir.global",
[IsolatedFromAbove, SingleBlockImplicitTerminator<"ReturnOp">, Symbol,
GlobalVariableLinkageOpInterface,
DeclareOpInterfaceMethods<GlobalValueLinkageOpInterface>,
DeclareOpInterfaceMethods<GlobalVariableLinkageOpInterface>]> {
Any hints?
There was a problem hiding this comment.
I wanted you to drop
/*methodBody=*/"",
/*defaultImplementation=*/[{ }]
and only add definition on missing classes
xlauko
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows both
linkage-b.mlirandlinkage-c.mlirto pass.