[mlir][mlir-link] Initial skeleton for an MLIR-linker #10
Conversation
This version can link two files. Probably not any two files/functions, but at least two specific test functions with one decl.
| return WalkResult::skip(); | ||
| }); | ||
|
|
||
| if (!anythingToLink) | ||
| // TODO: Consider if there are combinations of Function/GlobalVariable where |
There was a problem hiding this comment.
yes no global values will cause the function to proceed even if we can terminate
There was a problem hiding this comment.
Is this good or badf?
| DenseSet<Operation *> valuesToLink; | ||
| std::vector<Operation *> worklist; | ||
| // Replace-all-uses-with worklist | ||
| std::vector<std::pair<Operation *, Operation *>> rauwWorklist; |
There was a problem hiding this comment.
| std::vector<std::pair<Operation *, Operation *>> rauwWorklist; | |
| std::vector<std::pair<Operation *, Value>> rauwWorklist; |
mlir/lib/Linker/IRMover.cpp
Outdated
| } | ||
|
|
||
| if (dst) { | ||
| if (auto dstGVL = dyn_cast<GlobalValueLinkageOpInterface>(dst)) |
There was a problem hiding this comment.
| if (auto dstGVL = dyn_cast<GlobalValueLinkageOpInterface>(dst)) | |
| if (auto dgv = dyn_cast<GlobalValueLinkageOpInterface>(dst)) |
mlir/lib/Linker/IRMover.cpp
Outdated
|
|
||
| if (dst) { | ||
| if (auto dstGVL = dyn_cast<GlobalValueLinkageOpInterface>(dst)) | ||
| if (!dstGVL.isDeclarationForLinkage()) |
There was a problem hiding this comment.
| if (!dstGVL.isDeclarationForLinkage()) | |
| if (!(dgv.isDeclaration() || dgv.hasAvailableExternallyLinkage()) |
There was a problem hiding this comment.
isDeclarationForLinkage is not isDeclarationForLinker
There was a problem hiding this comment.
Could you please clarify? I don't follow.
| return LazilyAdded; | ||
| } | ||
|
|
||
| Operation *MLIRLinker::copyGlobalVariableProto(Operation *src, |
There was a problem hiding this comment.
I think we will do this as dialect interface. Where dialect will specify how to copy globals function etc.
There was a problem hiding this comment.
In that case, I think we'll have to have two separate phases (at least that is how it is done in llvm-linker), one for creating a prototype/declaration and one for copying the body.
This version can link two files. Probably not any two files/functions, but at least two specific test functions with one decl.