[MLIR][Interfaces] Do not use extraClassDefnition

trailofbits · Feb 7, 2025 · 2a631ae · 2a631ae
1 parent b388d6a
commit 2a631ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
@@ -782,11 +782,6 @@ def LLVM_CallOp : LLVM_MemAccessOpBase<"call",
     /// Returns the callee function type.
     LLVMFunctionType getCalleeFunctionType();
   }];
-  let extraClassDefinition = [{
-    std::optional<::mlir::StringRef> $cppClass::getUserSymbol() {
-      return getCallee();
-    }
-  }];
 }
 
 //===----------------------------------------------------------------------===//
@@ -1226,13 +1221,6 @@ def LLVM_AddressOfOp : LLVM_Op<"mlir.addressof",
     LLVMFuncOp getFunction(SymbolTableCollection &symbolTable);
 
   }];
-
-  let extraClassDefinition = [{
-    std::optional<::mlir::StringRef> $cppClass::getUserSymbol() {
-      return {getGlobalName()};
-    }
-  }];
-
   let assemblyFormat = "$global_name attr-dict `:` qualified(type($res))";
 
   let hasFolder = 1;

diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -1307,6 +1307,7 @@ LogicalResult CallOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
 
   return success();
 }
+std::optional<::mlir::StringRef> CallOp::getUserSymbol() { return getCallee(); }
 
 void CallOp::print(OpAsmPrinter &p) {
   auto callee = getCallee();
@@ -2071,6 +2072,10 @@ AddressOfOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
   return success();
 }
 
+std::optional<::mlir::StringRef> AddressOfOp::getUserSymbol() {
+  return getGlobalName();
+}
+
 // AddressOfOp constant-folds to the global symbol name.
 OpFoldResult LLVM::AddressOfOp::fold(FoldAdaptor) {
   return getGlobalNameAttr();