-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ChartReportPage.jsx #1316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pan and zoom, show dot only on mouse hover
Closed
Can you provide a screen capture of what it looks like now. |
fix error in build fail
Yes @tananaev Traccar.Chart.mov |
It doesn't look like the time is formatter in the |
Thank you, i have two suggestions, i could remove the time or leave it with a good format. see the two outcomes below Brush.time.formated.movBrush.time.removed.movWhich do you suggest? |
I guess the second option looks better for now. At least the text is not cut off. |
Hide time value in brush
tananaev
reviewed
Dec 26, 2024
tananaev
reviewed
Dec 26, 2024
tananaev
reviewed
Dec 26, 2024
move <line> tag attributes to different lines
removed unnecessary constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add pan to zoom and show dot only on mouse hover for the chart in the report page.