Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChartReportPage.jsx #1316

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Update ChartReportPage.jsx #1316

merged 5 commits into from
Dec 28, 2024

Conversation

hypoclone
Copy link
Contributor

This PR add pan to zoom and show dot only on mouse hover for the chart in the report page.

Add pan and zoom, show dot only on mouse hover
@hypoclone hypoclone mentioned this pull request Dec 26, 2024
@tananaev
Copy link
Member

Can you provide a screen capture of what it looks like now.

fix error in build fail
@hypoclone
Copy link
Contributor Author

Yes @tananaev

Traccar.Chart.mov

@tananaev
Copy link
Member

It doesn't look like the time is formatter in the Brush.

@hypoclone
Copy link
Contributor Author

Thank you, i have two suggestions, i could remove the time or leave it with a good format. see the two outcomes below

Brush.time.formated.mov
Brush.time.removed.mov

Which do you suggest?

@tananaev
Copy link
Member

I guess the second option looks better for now. At least the text is not cut off.

Hide time value in brush
move <line> tag attributes to different lines
removed unnecessary constants
@tananaev tananaev merged commit 9f85b7b into traccar:master Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants