Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
変更の根拠
height
指定の取りやめline-height
参考画像です
ディセンダーに関しては分かりやすいと思う
ちょうど文字が切れる位置で線が引かれているはずだし
PR Type
Bug fix, Enhancement
Description
.inputWrapper
のline-height
プロパティを削除しました。単一行の入力には不要なためです。.input
のheight
プロパティを1em
から100%
に変更し、テキストのクリッピング問題を解消しました。defineProps
を Vue 3.5 の仕様に合わせてデフォルト値を持つ分割代入に変更しました。iconSize
計算でprops.size
の代わりに分割代入されたsize
変数を使用するように調整しました。Changes walkthrough 📝
SearchInput.vue
Adjusted input height and props handling in SearchInput component
src/components/UI/SearchInput.vue
line-height
property from.inputWrapper
as it is unnecessaryfor single-line inputs.
height
property of.input
from1em
to100%
to avoid textclipping issues.
defineProps
to use destructuring with default values, aligningwith Vue 3.5 conventions.
iconSize
computation to use destructuredsize
variableinstead of
props.size
.