traPブログへのリンクを追加 #147
Merged
traPブログへのリンクを追加 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pugma
reviewed
Jun 11, 2024
| target="_blank" | ||
| rel="noreferrer noopener" | ||
| > | ||
| <img src="/@/assets/traP_logo_icon.svg" width="24" height="24" /> |
There was a problem hiding this comment.
ここでblogだけ別個で実装したのはsvgファイルを別個で用意しているからですかね…？
これで行くとAtCoderのロゴもこういう実装になるんですかね
There was a problem hiding this comment.
そうですね、ここだけ別です
AtCoderも確かに今のままでは無理ですが、AccountListItemコンポーネント自体の実装を修正すれば多分いい感じにsvgにもアイコンにも対応できるようにはできそうです(まだロゴ用意できてなさそうなので今はこのままで)
There was a problem hiding this comment.
あ〜、だとするとAtCoderのsvgが用意できた状態でAccountListItemの実装を直す感じになるんですかね…？
Pugma
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #136