Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

参加プロジェクトとかがないときの表示 #145

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Jun 8, 2024

close #143

@mehm8128 mehm8128 requested a review from Pugma June 8, 2024 13:08
@mehm8128 mehm8128 self-assigned this Jun 8, 2024
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装ありがとうございます!
方法自体は (そこまで書いてもないし) これでいいんですが、ちょっと表現だけ確認してみてほしいです

src/components/User/ContestsContainer.vue Outdated Show resolved Hide resolved
src/components/User/ProjectsContainer.vue Outdated Show resolved Hide resolved
src/components/User/GroupsContainer.vue Outdated Show resolved Hide resolved
@mehm8128
Copy link
Contributor Author

表現迷ったから助かった

@mehm8128 mehm8128 requested a review from Pugma June 10, 2024 12:32
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

度重なる修正依頼にお応えくださってありがとうございました!

@mehm8128 mehm8128 merged commit e9cd8f3 into master Jun 11, 2024
8 checks passed
@mehm8128 mehm8128 deleted the feat/no_project_no_group_no_contest branch June 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

なんも活動してないときの表示をどうにかする
2 participants