Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/UI直した #126

Merged
merged 13 commits into from
Jun 1, 2024
Merged

feat/UI直した #126

merged 13 commits into from
Jun 1, 2024

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented May 20, 2024

close #41
パンくずリストはissue立てておくので誰かやりたい人いれば別でやってくださいということで
誰もやらなかったらいつかやります

全部見るの大変なので、大体動いてるかどうか確認できたら大丈夫だと思います多分
トップページとイベントページはやってないです

@mehm8128 mehm8128 self-assigned this May 20, 2024
@mehm8128 mehm8128 marked this pull request as draft May 20, 2024 12:22
@mehm8128 mehm8128 requested a review from Pugma May 20, 2024 12:59
@mehm8128 mehm8128 marked this pull request as ready for review May 20, 2024 13:04
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

だいたい確認しました
1点確認なんですが、gridからflexに変更した理由とかありますか…?
grid でも1列での配置や、gapの設定ができると思います…

@mehm8128
Copy link
Contributor Author

mehm8128 commented Jun 1, 2024

gridからflexに変更した理由

1次元のときは僕は基本flexを使いがちなのでそっち使った、くらいの理由です
grid使った方がよさそうなら変えます

@mehm8128 mehm8128 requested a review from Pugma June 1, 2024 12:34
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この一点だけ修正をお願いします!

flexについてはこのままで大丈夫です
理由もお答えくださってありがとうございました

</div>
<admin-list :admins="groupDetail.admin" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここで admin-listを使ってますが、インポートできてなさそうです

@mehm8128 mehm8128 requested a review from Pugma June 1, 2024 12:58
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!
修正の対応もしてくださってありがとうございました:pray:

@mehm8128 mehm8128 merged commit edda7ef into master Jun 1, 2024
6 checks passed
@mehm8128 mehm8128 deleted the feat/ui branch June 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

デザインを修正したい
2 participants