Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgraded node LTS #417

Merged
merged 1 commit into from
Jan 17, 2025
Merged

chore: upgraded node LTS #417

merged 1 commit into from
Jan 17, 2025

Conversation

Pugma
Copy link
Collaborator

@Pugma Pugma commented Jan 7, 2025

User description

traPtitech/traPortfolio-UI#265 同様


PR Type

enhancement


Description

  • Node.jsのバージョンを22.12.0にアップグレード

  • Dockerfile内のNode.jsイメージを更新


Changes walkthrough 📝

Relevant files
Enhancement
.node-version
Node.jsバージョンを更新                                                                                   

.node-version

  • Node.jsのバージョンを22.11.0から22.12.0に更新
+1/-1     
Dockerfile
DockerfileのNode.jsイメージを更新                                                               

Dockerfile

  • Node.jsイメージを20.11.1-alpineから22.12.0-alpineに更新
+1/-1     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Update

Ensure that all dependencies and configurations are compatible with Node.js version 22.12.0, as this update might introduce breaking changes or require adjustments.

FROM --platform=$BUILDPLATFORM node:22.12.0-alpine AS build

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@Pugma Pugma requested a review from sh0go07 January 7, 2025 08:47
@Pugma Pugma enabled auto-merge January 7, 2025 08:47
@Pugma Pugma requested a review from Kaki256 January 10, 2025 10:34
Copy link
Contributor

@sh0go07 sh0go07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI の方と同じく!
よさそうです!

@Pugma Pugma merged commit e8ae196 into main Jan 17, 2025
10 checks passed
@Pugma Pugma deleted the updateNode branch January 17, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants