Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

第一部のreact編 #130

Merged
merged 10 commits into from
May 12, 2024
Merged

第一部のreact編 #130

merged 10 commits into from
May 12, 2024

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Apr 29, 2024

例年ハッカソンでReact使いたいチームもあるので、そういうチーム向けです(実際去年この内容を別でデプロイしたものはいくつかのチームに使われていました)
本編をやった人を想定しているので、重複しそうな部分は除いています
画像は一部去年nextで作ったものからそのままにしてるので、背景色が白じゃなくて灰色になってます

どこに表示&ファイルを配置すればいいか分からなかったので、良さげな場所があれば教えてほしいです
実習編と同じ階層に、おまけみたいなのを作るのがよさそうかなとちょっと思ってます

@mehm8128 mehm8128 self-assigned this Apr 29, 2024
@mehm8128 mehm8128 changed the title react react編 Apr 29, 2024
@mehm8128 mehm8128 changed the title react編 第一部のreact編 Apr 29, 2024
@mehm8128 mehm8128 marked this pull request as ready for review April 29, 2024 15:51
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

みました

docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
docs/chapter1/dicts/react/0_react-intro.md Outdated Show resolved Hide resolved
@mehm8128 mehm8128 requested a review from cp-20 May 12, 2024 03:21
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう

@mehm8128 mehm8128 merged commit 36a7ed1 into main May 12, 2024
3 checks passed
@mehm8128 mehm8128 deleted the feat/react branch May 12, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants