assert vs require
#830
Open
assert vs require
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests_testは未対応
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #830 +/- ##
==========================================
- Coverage 25.30% 25.29% -0.01%
==========================================
Files 147 148 +1
Lines 30769 30823 +54
==========================================
+ Hits 7787 7798 +11
- Misses 22095 22135 +40
- Partials 887 890 +3 ☔ View full report in Codecov by Sentry. |
…ests_parameters requestsにLimitとOffsetパラメータを追加
Fixed `admin_test.go`, `file_test.go`, `group_test.go`
✅ Testでgo-cmpを使うように
…n into change_assert_to_require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#821
ひとまず
router/admin_test.goの中身のみ変更基本
assertをrequireに変更していったがHTTPステータスとresBodyの比較する部分はエラー時に両方見れた方がいいと思ったのでassertのままにしたresuireに変更する中で不要なif文を消した