Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /requests?created_by #826

Merged
merged 4 commits into from
Dec 27, 2024
Merged

GET /requests?created_by #826

merged 4 commits into from
Dec 27, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Dec 26, 2024

close #818

  • 実装
  • swagger
  • test

@H1rono H1rono force-pushed the requests-query-created_by branch from d078af9 to 6cf1c49 Compare December 26, 2024 10:18
@H1rono
Copy link
Member Author

H1rono commented Dec 26, 2024

memo

2024-12-26T10:20:28.9317617Z     --- FAIL: TestEntRepository_GetRequests/SuccessWithCreatedBy (0.05s)
2024-12-26T10:20:28.9318150Z         request_impl_test.go:647: 
2024-12-26T10:20:28.9318860Z             	Error Trace:	/home/runner/work/Jomon/Jomon/model/request_impl_test.go:647
2024-12-26T10:20:28.9319377Z             	Error:      	Not equal: 
2024-12-26T10:20:28.9320733Z             	            	expected: uuid.UUID{0x8, 0xea, 0x78, 0xe5, 0x30, 0x1d, 0x4d, 0x12, 0xa0, 0x30, 0xeb, 0x57, 0x0, 0xc2, 0x49, 0x9b}
2024-12-26T10:20:28.9322438Z             	            	actual  : uuid.UUID{0xeb, 0x64, 0x9e, 0x34, 0x42, 0x69, 0x4b, 0x89, 0x98, 0x6, 0x73, 0x44, 0x41, 0x9d, 0x32, 0xfe}
2024-12-26T10:20:28.9323022Z             	            	
2024-12-26T10:20:28.9323347Z             	            	Diff:
2024-12-26T10:20:28.9323845Z             	            	--- Expected
2024-12-26T10:20:28.9324229Z             	            	+++ Actual
2024-12-26T10:20:28.9324721Z             	            	@@ -1,3 +1,3 @@
2024-12-26T10:20:28.9325496Z             	            	 (uuid.UUID) (len=16) {
2024-12-26T10:20:28.9326496Z             	            	- 00000000  08 ea 78 e5 30 1d 4d 12  a0 30 eb 57 00 c2 49 9b  |..x.0.M..0.W..I.|
2024-12-26T10:20:28.9327789Z             	            	+ 00000000  eb 64 9e 34 42 69 4b 89  98 06 73 44 41 9d 32 fe  |.d.4BiK...sDA.2.|
2024-12-26T10:20:28.9328203Z             	            	 }
2024-12-26T10:20:28.9328805Z             	Test:       	TestEntRepository_GetRequests/SuccessWithCreatedBy

@H1rono H1rono force-pushed the requests-query-created_by branch from 6cf1c49 to dba9bc8 Compare December 27, 2024 04:41
@H1rono
Copy link
Member Author

H1rono commented Dec 27, 2024

うーん

2024-12-27T04:42:41.1807966Z     --- FAIL: TestEntRepository_GetRequests/SuccessWithQueryCreatedBy (0.03s)
2024-12-27T04:42:41.1808772Z         request_impl_test.go:665: 
2024-12-27T04:42:41.1809941Z             	Error Trace:	/home/runner/work/Jomon/Jomon/model/request_impl_test.go:665
2024-12-27T04:42:41.1811035Z             	Error:      	Not equal: 
2024-12-27T04:42:41.1823133Z             	            	expected: &model.RequestResponse{ID:uuid.UUID{0x1f, 0xe7, 0x8b, 0xeb, 0xf7, 0x9b, 0x40, 0x88, 0x83, 0xb5, 0xc2, 0xb7, 0xdb, 0x47, 0xf, 0xb9}, Status:1, CreatedAt:time.Date(2024, time.December, 27, 4, 42, 31, 0, time.Local), UpdatedAt:time.Date(2024, time.December, 27, 4, 42, 31, 0, time.Local), CreatedBy:uuid.UUID{0xfa, 0x8c, 0x3e, 0x3, 0x9e, 0x4, 0x46, 0x3b, 0xb3, 0xe8, 0x99, 0x44, 0xbd, 0x8d, 0x3f, 0x8b}, Title:"xL4VqDigG11q2dsNKiGJTvHkMeD3m3kusCU02mdH", Content:"5l5I9peGBJkDQyVvq9kKYbAeZgGnCPh9VZmd9bOUg5INGqFeu5OcwThcHHIz3WlQ6H2ZaOjaecAC9mAfMN6XXS3CAw8DoW2HmrY3", Tags:[]*model.Tag{}, Targets:[]*model.RequestTargetDetail(nil), Statuses:[]*model.RequestStatus(nil), Group:(*model.Group)(0xc0002de230)}
2024-12-27T04:42:41.1838510Z             	            	actual  : &model.RequestResponse{ID:uuid.UUID{0x1f, 0xe7, 0x8b, 0xeb, 0xf7, 0x9b, 0x40, 0x88, 0x83, 0xb5, 0xc2, 0xb7, 0xdb, 0x47, 0xf, 0xb9}, Status:1, CreatedAt:time.Date(2024, time.December, 27, 4, 42, 31, 0, time.Local), UpdatedAt:time.Date(2024, time.December, 27, 4, 42, 31, 0, time.Local), CreatedBy:uuid.UUID{0xfa, 0x8c, 0x3e, 0x3, 0x9e, 0x4, 0x46, 0x3b, 0xb3, 0xe8, 0x99, 0x44, 0xbd, 0x8d, 0x3f, 0x8b}, Title:"xL4VqDigG11q2dsNKiGJTvHkMeD3m3kusCU02mdH", Content:"5l5I9peGBJkDQyVvq9kKYbAeZgGnCPh9VZmd9bOUg5INGqFeu5OcwThcHHIz3WlQ6H2ZaOjaecAC9mAfMN6XXS3CAw8DoW2HmrY3", Tags:[]*model.Tag{}, Targets:[]*model.RequestTargetDetail(nil), Statuses:[]*model.RequestStatus(nil), Group:(*model.Group)(0xc000295dc0)}
2024-12-27T04:42:41.1842566Z             	            	
2024-12-27T04:42:41.1843375Z             	            	Diff:
2024-12-27T04:42:41.1843777Z             	            	--- Expected
2024-12-27T04:42:41.1844164Z             	            	+++ Actual
2024-12-27T04:42:41.1844575Z             	            	@@ -82,4 +82,4 @@
2024-12-27T04:42:41.1845089Z             	            	   CreatedAt: (time.Time) {
2024-12-27T04:42:41.1845686Z             	            	-   wall: (uint64) 13966693708273389647,
2024-12-27T04:42:41.1846198Z             	            	-   ext: (int64) 4789605310,
2024-12-27T04:42:41.1846656Z             	            	+   wall: (uint64) 0,
2024-12-27T04:42:41.1847155Z             	            	+   ext: (int64) 63870871351,
2024-12-27T04:42:41.1847682Z             	            	    loc: (*time.Location)({
2024-12-27T04:42:41.1848127Z             	            	@@ -112,4 +112,4 @@
2024-12-27T04:42:41.1848702Z             	            	   UpdatedAt: (time.Time) {
2024-12-27T04:42:41.1849309Z             	            	-   wall: (uint64) 13966693708273392542,
2024-12-27T04:42:41.1849822Z             	            	-   ext: (int64) 4789608216,
2024-12-27T04:42:41.1850276Z             	            	+   wall: (uint64) 0,
2024-12-27T04:42:41.1850764Z             	            	+   ext: (int64) 63870871351,
2024-12-27T04:42:41.1851284Z             	            	    loc: (*time.Location)({
2024-12-27T04:42:41.1851849Z             	Test:       	TestEntRepository_GetRequests/SuccessWithQueryCreatedBy

@H1rono H1rono force-pushed the requests-query-created_by branch from 56f8f42 to 507082f Compare December 27, 2024 07:49
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 25.30%. Comparing base (0a3f9e2) to head (507082f).
Report is 8 commits behind head on v2.

Files with missing lines Patch % Lines
router/request.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #826      +/-   ##
==========================================
+ Coverage   25.23%   25.30%   +0.07%     
==========================================
  Files         147      147              
  Lines       30735    30752      +17     
==========================================
+ Hits         7757     7783      +26     
+ Misses      22092    22082      -10     
- Partials      886      887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono merged commit 62b926a into v2 Dec 27, 2024
7 checks passed
@H1rono H1rono deleted the requests-query-created_by branch December 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /requests?created_by=uuid
1 participant