Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add & to custom file trait #51

Merged
merged 1 commit into from
Oct 4, 2024
Merged

add & to custom file trait #51

merged 1 commit into from
Oct 4, 2024

Conversation

hayatroid
Copy link
Collaborator

@hayatroid hayatroid commented Oct 4, 2024 •
edited
Loading

関連Issue

概要

create_hardlink_of の引数 original: FileType は original: &FileType であるべき

変更内容

& を付け加えた

チェックリスト

  • テストが通っている
  • 下記のいずれかを満たしている
      • 変更点についてテストを追加/修正した
      • テストを追加するissueを立てた
      • テストが不要な変更である
  • レビュワーを指定した
  • タグをつけた

補足

@hayatroid hayatroid added the bug Something isn't working label Oct 4, 2024
@hayatroid hayatroid requested a review from comavius October 4, 2024 09:35
@comavius comavius changed the title add & add & to custom file trait Oct 4, 2024
comavius
comavius approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@comavius comavius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayatroid hayatroid merged commit 7a52322 into develop Oct 4, 2024
3 of 4 checks passed
@hayatroid hayatroid deleted the feat/#49-add-ref branch October 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comavius comavius comavius approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom_file の trait の修正
2 participants
@hayatroid @comavius