Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#58 db scheme #72

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Fix/#58 db scheme #72

merged 5 commits into from
Dec 13, 2024

Conversation

PonponJuice
Copy link
Collaborator

@PonponJuice PonponJuice commented Dec 12, 2024

関連Issue

概要

時間周りの変数名が一致していないので修正
testcaseの変数名をopenAPIのものとできるだけ合わせた

変更内容

  • publish を created にした
  • time を at にした
  • testcase_* からtestcase_ を削除した

補足

@PonponJuice PonponJuice linked an issue Dec 12, 2024 that may be closed by this pull request
@PonponJuice
Copy link
Collaborator Author

JudgeCode, submissionのコードをデータベースで持つならこっちも持っても良さそうかも

@kenken714 kenken714 self-requested a review December 13, 2024 07:00
`id` INT AUTO_INCREMENT PRIMARY KEY,
`name` VARCHAR(255) NOT NULL,
`path` VARCHAR(255) NOT NULL,
`problem_id` INT NOT NULL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created_at, updated_atいるかも

migrations/0_create-table.sql Show resolved Hide resolved
Copy link
Collaborator

@kenken714 kenken714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheme はよさそう

@kenken714
Copy link
Collaborator

これこのissueでhandlerも直しますか

Copy link
Collaborator

@kenken714 kenken714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenken714 kenken714 merged commit 6c585ae into develop Dec 13, 2024
1 check passed
@kenken714 kenken714 deleted the fix/#58-db-scheme branch December 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB scheme の timeの接尾辞の不一致を修正
2 participants