Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat#46 users integration test #51

Merged
merged 19 commits into from
Dec 13, 2024
Merged

Feat#46 users integration test #51

merged 19 commits into from
Dec 13, 2024

Conversation

PonponJuice
Copy link
Collaborator

@PonponJuice PonponJuice commented Oct 31, 2024 •
edited
Loading

関連Issue

概要

databaseを使ったCIをするためのworkflowの変更
/users を確かめるための統合テストの追加

変更内容

  • github/workflow の変更
  • GET users/me,users/{:userId} のテストを作成

補足

github workflow が正しいのか確認のために一旦投げます

@PonponJuice PonponJuice linked an issue Oct 31, 2024 that may be closed by this pull request
usersの統合テストを記述する #46
Closed
@kenken714
Copy link
Collaborator

これいまレビューできる状態になっていますか...？ @PonponJuice

@PonponJuice PonponJuice requested a review from kenken714 November 7, 2024 05:53
@PonponJuice
Copy link
Collaborator Author

お願いします

kenken714
kenken714 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@kenken714 kenken714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenken714 kenken714 merged commit 90ac17a into develop Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenken714 kenken714 kenken714 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usersの統合テストを記述する
2 participants
@PonponJuice @kenken714