第4章の練習問題「Fibonatti Number」を修正 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takeno-hito
reviewed
May 18, 2024
| @@ -24,7 +26,7 @@ int main() { | |||
| int n; | |||
| cin >> n; | |||
| int second_latest = 0, latest = 1; | |||
| for (int i = 2; i < n; i++) { | |||
| for (int i = 1; i < n; i++) { | |||
There was a problem hiding this comment.
回数のためにしか使ってないなら
Suggested change
| for (int i = 1; i < n; i++) { | |
| for (int i = 0; i < n-1; i++) { |
Suggested change
| for (int i = 1; i < n; i++) { | |
| for (int i = 2; i <= n; i++) { |
としたいです
There was a problem hiding this comment.
返信遅くなりすみません.
i番目を計算するほうが分かりやすいと思うので, その旨のコメントを追加して以下でどうでしょうか.
Suggested change
| for (int i = 1; i < n; i++) { | |
| for (int i = 2; i <= n; i++) { | |
| // i番目を計算 |
| @@ -44,11 +46,11 @@ int main() { | |||
| int n; | |||
| cin >> n; | |||
| vector<int> fibonatti_sequence = {0, 1}; | |||
| for (int i = 2; i < n; i++) { | |||
| for (int i = 1; i < n; i++) { | |||
There was a problem hiding this comment.
上と同様です.
Suggested change
| for (int i = 1; i < n; i++) { | |
| for (int i = 2; i <= n; i++) { | |
| // i番目を計算 |
フィボナッチ数列のi番目を計算していることが分かりやすいようにした.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
何をしたか
整数N→正の整数N