Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

✨ GitHub Actionsでterraform fmtを実行してコミットする #25

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Jul 4, 2024

traP-jp members Pull Request

まだ実験中

この変更の目的

terraformをインストールしてもらって手元でterraform fmtしてもらうのは大変なので、CIでやる

GitHub IDとtraQ IDの対応

備考

加えた変更で、IDにtypoが無いことを確認しましたか?

typoした先が実在するIDだった場合、無関係な人にtraP-jpへの招待が飛ぶなどの可能性があります。

  • 確認した

@ikura-hamu ikura-hamu requested a review from a team as a code owner July 4, 2024 13:56
Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.members.github_membership.member["Hyde616"] will be created
  + resource "github_membership" "member" {
      + downgrade_on_destroy = false
      + etag                 = (known after apply)
      + id                   = (known after apply)
      + role                 = "member"
      + username             = "Hyde616"
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 1 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

1 similar comment
Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.members.github_membership.member["Hyde616"] will be created
  + resource "github_membership" "member" {
      + downgrade_on_destroy = false
      + etag                 = (known after apply)
      + id                   = (known after apply)
      + role                 = "member"
      + username             = "Hyde616"
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 1 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

github-actions bot commented Jul 4, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "cho3881392697"
        }
      + members {
          + role     = "member"
          + username = "shobonvip"
        }
      + members {
          + role     = "member"
          + username = "yuiveslkao"
        }

        # (19 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

.github/workflows/plan.yml Outdated Show resolved Hide resolved
.github/workflows/plan.yml Outdated Show resolved Hide resolved
run: test ${{ steps.fmt.outputs.stdout }} == ''

- name: Commit changes
if: steps.fmt.outputs.stdout != ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ息してる?それとも上のtestの部分が働いてない?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

息してると思うけど、どの辺が息してなかった?

想定してる挙動は、

  • workflow_dispatchでfmtにdiffがあったら異常終了
  • workflow_dispatchでfmtにdiffが無かったら何もせず正常終了
  • PRでfmtにdiffが無かったら何もせず正常終了
  • PRでfmtにdiffがあったらコミット

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ifのところ、testとやりたいこと同じじゃない?という意味でした

.github/workflows/plan.yml Outdated Show resolved Hide resolved
@ikura-hamu
Copy link
Member Author

traQでも書いたけど、これをやるとPRの最新のコミットがbotからになり、GitHub Actionsが走らないからbranch protectionにかかって進めなくなるので、draftにしておく

Copy link

github-actions bot commented Jul 7, 2024

terraform plan

Acquiring state lock. This may take a few moments...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.teams["traOJudge"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10492474"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "shobonvip"
        }

        # (21 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_children_teams["h24s_04"].github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10301520"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "maintainer"
          + username = "Hyde616"
        }

        # (4 unchanged blocks hidden)
    }

  # module.hackathon.module.h24s_parent_team.github_team_members.team_members will be updated in-place
  ~ resource "github_team_members" "team_members" {
        id      = "10278337"
        # (1 unchanged attribute hidden)

      + members {
          + role     = "member"
          + username = "Hyde616"
        }

        # (72 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

guarantee to take exactly these actions if you run "terraform apply" now.

@ikura-hamu ikura-hamu marked this pull request as draft July 7, 2024 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants