This repository has been archived by the owner on Aug 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
✨ GitHub Actionsでterraform fmtを実行してコミットする #25
Draft
ikura-hamu
wants to merge
20
commits into
main
Choose a base branch
from
feat/auto_fmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 similar comment
|
|
|
|
|
|
|
|
H1rono
reviewed
Jul 6, 2024
run: test ${{ steps.fmt.outputs.stdout }} == '' | ||
|
||
- name: Commit changes | ||
if: steps.fmt.outputs.stdout != '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ息してる?それとも上のtest
の部分が働いてない?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
息してると思うけど、どの辺が息してなかった?
想定してる挙動は、
- workflow_dispatchでfmtにdiffがあったら異常終了
- workflow_dispatchでfmtにdiffが無かったら何もせず正常終了
- PRでfmtにdiffが無かったら何もせず正常終了
- PRでfmtにdiffがあったらコミット
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
のところ、test
とやりたいこと同じじゃない?という意味でした
traQでも書いたけど、これをやるとPRの最新のコミットがbotからになり、GitHub Actionsが走らないからbranch protectionにかかって進めなくなるので、draftにしておく |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traP-jp members Pull Request
まだ実験中
この変更の目的
terraformをインストールしてもらって手元で
terraform fmt
してもらうのは大変なので、CIでやるGitHub IDとtraQ IDの対応
備考
加えた変更で、IDにtypoが無いことを確認しましたか?
typoした先が実在するIDだった場合、無関係な人にtraP-jpへの招待が飛ぶなどの可能性があります。