Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メッセージのアイコンと本体のレイヤーを分ける #99

Merged
merged 6 commits into from
Jan 25, 2025

Conversation

ikura-hamu
Copy link
Member

  • ✨ メッセージを表示する
  • ♻️ messagesAtomに名前変える
  • ✨ フィールドの中か外かを判定

@ikura-hamu ikura-hamu requested a review from Copilot January 25, 2025 14:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • client/src/pixi/components/Message.tsx: Evaluated as low risk
Comments suppressed due to low confidence (4)

client/src/pixi/components/MessageIcon.tsx:14

  • [nitpick] The component name ExpandedIcon is misleading. It should be renamed to MessageIcon.
const ExpandedIcon: React.FC<Props> = ({

client/src/pixi/components/MessageIcon.tsx:32

  • [nitpick] Consider using onClick instead of onmouseover to avoid accidental expansions.
onmouseover={() => {

client/src/pixi/components/MessageIcon.tsx:9

  • [nitpick] The prop currentExpandedMessageId should be renamed to expandedMessageId for consistency.
currentExpandedMessageId: string | undefined;

client/src/pixi/hooks/message.ts:5

  • [nitpick] Consider renaming 'expanded' to 'isExpanded' for better readability.
const [expanded, setExpanded] = useState(false);
@ikura-hamu ikura-hamu merged commit 27f2f13 into main Jan 25, 2025
5 checks passed
@ikura-hamu ikura-hamu deleted the client/feat/message_layer branch January 25, 2025 15:03
@ikura-hamu ikura-hamu linked an issue Jan 25, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: メッセージをフィールドに表示
1 participant