フィールド上のメッセージのUI #33
Merged
フィールド上のメッセージのUI #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikura-hamu
commented
Jan 22, 2025
ikura-hamu
commented
- ✨ メッセージアイコンを準備
- ✨ メッセージコンポーネント
- 💄 tailwindの色をpixi用にtypescriptに持ってくる
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
client/src/pixi/theme.ts:21
- Ensure that the keys in the themeColors object are correctly mapped from the Tailwind config to avoid potential typos.
backgroundPrimary: colors["background-primary"],
Closed
SSlime-s
requested changes
Jan 22, 2025
Comment on lines
+56
to
+65
| useEffect(() => { | ||
| if (!showMessage) return; | ||
| if (textRef.current) { | ||
| const { width, height } = textRef.current; | ||
| setBubbleSize({ | ||
| width: width + 20, | ||
| height: height + 20, | ||
| }); | ||
| } | ||
| }, [showMessage]); |
There was a problem hiding this comment.
余裕なかったらこのままでいいけど、setShowMessage をラップして、setShowMessage(true) するときにsetBubbleSize するのがよさそう
There was a problem hiding this comment.
これshowMessage=falseのときtextRef.currentがnullなのでできなさそうです
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.