Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フィールドにいろいろを表示 #104

Merged
merged 8 commits into from
Jan 25, 2025
Merged

Conversation

ikura-hamu
Copy link
Member

fix: #11
fix: #12
fix: #13

  • ✨ speakerPhoneの配置
  • ♻️ fieldSpeakerPhonesAtom -> speakerPhonesAtom
  • ✨ reactionの表示
  • ♻️ fieldReactionsAtom -> reactionsAtom
  • ✨ 他のexplorerの表示
  • ♻️ fieldExplorersAtom => explorersAtom

@ikura-hamu ikura-hamu requested a review from Copilot January 25, 2025 16:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

client/src/pixi/components/OtherExplorer.tsx:25

  • The position update logic inside useTick might cause an infinite loop if the position is not updated correctly. Ensure the diff calculation and position update logic are correct.
setPosition((pos) => {
@ikura-hamu ikura-hamu merged commit 5fa3ee2 into main Jan 25, 2025
5 checks passed
@ikura-hamu ikura-hamu deleted the client/display_items branch January 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant