Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAPI: Fix state handling in policy execute 3.2.x. #2769

Conversation

JuergenReppSIT
Copy link
Member

The state was not initialized correctly in error cases in the policy utility state machines.

The state was not initialized correctly in error cases in
the policy utility state machines.

Signed-off-by: Juergen Repp <[email protected]>
@JuergenReppSIT JuergenReppSIT changed the title FAPI: Fix state handling in policy execute. FAPI: Fix state handling in policy execute 3.2.x. Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (fb92f8d) 83.64% compared to head (fdbf03d) 83.60%.
Report is 2 commits behind head on 3.2.x.

Files Patch % Lines
src/tss2-fapi/fapi_util.c 65.00% 7 Missing ⚠️
src/tss2-fapi/api/Fapi_GetTpmBlobs.c 33.33% 2 Missing ⚠️
src/tss2-fapi/api/Fapi_Provision.c 50.00% 2 Missing ⚠️
src/tss2-fapi/ifapi_policyutil_execute.c 66.66% 2 Missing ⚠️
src/tss2-fapi/api/Fapi_Decrypt.c 0.00% 1 Missing ⚠️
src/tss2-fapi/api/Fapi_Delete.c 83.33% 1 Missing ⚠️
src/tss2-fapi/api/Fapi_GetCertificate.c 50.00% 1 Missing ⚠️
src/tss2-fapi/api/Fapi_GetDescription.c 50.00% 1 Missing ⚠️
src/tss2-fapi/api/Fapi_GetEsysBlob.c 0.00% 1 Missing ⚠️
src/tss2-fapi/api/Fapi_GetRandom.c 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##            3.2.x    #2769      +/-   ##
==========================================
- Coverage   83.64%   83.60%   -0.05%     
==========================================
  Files         349      349              
  Lines       38693    38726      +33     
==========================================
+ Hits        32366    32377      +11     
- Misses       6327     6349      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuergenReppSIT JuergenReppSIT merged commit dde17cf into tpm2-software:3.2.x Feb 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants